aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjörn Gustavsson <[email protected]>2019-02-13 10:02:23 +0100
committerBjörn Gustavsson <[email protected]>2019-02-15 10:37:40 +0100
commitf7a4d01b660bc5532bdd77679bbe3d6831ead597 (patch)
treed1f3f5b03a97e14b8bf300a0f1680d0b7973c757
parent83e5069e94209242d59de45bb5f50014413b63e9 (diff)
downloadotp-f7a4d01b660bc5532bdd77679bbe3d6831ead597.tar.gz
otp-f7a4d01b660bc5532bdd77679bbe3d6831ead597.tar.bz2
otp-f7a4d01b660bc5532bdd77679bbe3d6831ead597.zip
Don't limit the number of processes when running cover
With the recent update to cover to use the `counters` modules, there is no longer any reason to limit the number of parallel processes when running `cover`.
-rw-r--r--lib/compiler/test/test_lib.erl19
1 files changed, 2 insertions, 17 deletions
diff --git a/lib/compiler/test/test_lib.erl b/lib/compiler/test/test_lib.erl
index 7fb4751b42..8b24e1b025 100644
--- a/lib/compiler/test/test_lib.erl
+++ b/lib/compiler/test/test_lib.erl
@@ -50,12 +50,8 @@ smoke_disasm(File) when is_list(File) ->
Res = beam_disasm:file(File),
{beam_file,_Mod} = {element(1, Res),element(2, Res)}.
-%% If we are running cover, we don't want to run test cases that
-%% invokes the compiler in parallel, as doing so would probably
-%% be slower than running them sequentially.
-
parallel() ->
- case test_server:is_cover() orelse erlang:system_info(schedulers) =:= 1 of
+ case erlang:system_info(schedulers) =:= 1 of
true -> [];
false -> [parallel]
end.
@@ -117,18 +113,7 @@ is_cloned_mod_1([]) -> false.
p_run(Test, List) ->
S = erlang:system_info(schedulers),
- N = case test_server:is_cover() of
- false ->
- S + 1;
- true ->
- %% Cover is running. Using too many processes
- %% could slow us down. Measurements on my computer
- %% showed that using 4 parallel processes was
- %% slightly faster than using 3. Using more than
- %% 4 would not buy us much and could actually be
- %% slower.
- min(S, 4)
- end,
+ N = S + 1,
io:format("p_run: ~p parallel processes\n", [N]),
p_run_loop(Test, List, N, [], 0, 0).