diff options
| author | John Högberg <[email protected]> | 2019-03-27 15:32:29 +0100 |
|---|---|---|
| committer | John Högberg <[email protected]> | 2019-03-27 16:25:59 +0100 |
| commit | 0398c6868940af8561d3401c00441071c57d7ac5 (patch) | |
| tree | db87851c6ed8ac495e2e77e27403144049b97fd0 /erts/emulator/beam/ops.tab | |
| parent | edb8aa4f76981c1f32c9b429f47ce30100126e58 (diff) | |
| download | otp-0398c6868940af8561d3401c00441071c57d7ac5.tar.gz otp-0398c6868940af8561d3401c00441071c57d7ac5.tar.bz2 otp-0398c6868940af8561d3401c00441071c57d7ac5.zip | |
erts: Remove unsafe bs_get_binary2 optimization from loader
A load-time optimization assumed that match contexts had no further
uses when a bs_get_binary2 overwrote the match context's register,
and figured it would be safe to reuse the match context's memory
for the resulting binary.
This is no longer safe as of OTP 22, as a match context may be
reused after being passed to another function.
Diffstat (limited to 'erts/emulator/beam/ops.tab')
| -rw-r--r-- | erts/emulator/beam/ops.tab | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/erts/emulator/beam/ops.tab b/erts/emulator/beam/ops.tab index 6832e65b1b..abbddbb41f 100644 --- a/erts/emulator/beam/ops.tab +++ b/erts/emulator/beam/ops.tab @@ -1262,7 +1262,6 @@ bs_get_binary2 Fail=f Ms=xy Live=u Sz=sq Unit=u Flags=u Dst=d => \ i_bs_get_binary_imm2 xy f? t W t d i_bs_get_binary2 xy f t? s t d i_bs_get_binary_all2 xy f? t t d -i_bs_get_binary_all_reuse xy f? t # Fetching float from binaries. bs_get_float2 Fail=f Ms=xy Live=u Sz=s Unit=u Flags=u Dst=d => \ |