aboutsummaryrefslogtreecommitdiffstats
path: root/lib/asn1/test/testChoExtension.erl
diff options
context:
space:
mode:
authorBjörn Gustavsson <[email protected]>2014-12-04 15:03:39 +0100
committerBjörn Gustavsson <[email protected]>2015-01-12 12:22:57 +0100
commit7129f2acb474651fa4ef922b24ff18dd84dd9c77 (patch)
treeb81530ce37bec432b7256e176554646b6d55058e /lib/asn1/test/testChoExtension.erl
parent4247459eded419b9e693cfbfaf8746f4f6f60d2c (diff)
downloadotp-7129f2acb474651fa4ef922b24ff18dd84dd9c77.tar.gz
otp-7129f2acb474651fa4ef922b24ff18dd84dd9c77.tar.bz2
otp-7129f2acb474651fa4ef922b24ff18dd84dd9c77.zip
asn1ct_parser2: Clean up error handling and reporting
Errors were reported using a throw like this: throw({asn1_error,{get_line(hd(Tokens)),get(asn1_module), [got,get_token(hd(Tokens)),expected,typereference]}}). The attempt to tell the user what was expected was often mis-leading. It is time-consuming and non-trival to provide correct information of what is expected. Therefore, we will not even try. Instead we will spend more effort to report the token where the error was discovered. We will replace each throw with a function call: parse_error(Tokens). Also add the syntax_SUITE test suite to test error reporting and to cover all error reporting code. Remove the old c_syntax/1 test case. Also remove all out-commented code.
Diffstat (limited to 'lib/asn1/test/testChoExtension.erl')
-rw-r--r--lib/asn1/test/testChoExtension.erl5
1 files changed, 0 insertions, 5 deletions
diff --git a/lib/asn1/test/testChoExtension.erl b/lib/asn1/test/testChoExtension.erl
index 09e19ceebb..f36d6c1cbf 100644
--- a/lib/asn1/test/testChoExtension.erl
+++ b/lib/asn1/test/testChoExtension.erl
@@ -39,11 +39,6 @@ extension(_Rules) ->
roundtrip('ChoExt3', {int,33}),
roundtrip('ChoExt4', {str,<<"abc">>}),
- roundtrip('ChoEmptyRoot', {bool,false}),
- roundtrip('ChoEmptyRoot', {bool,true}),
- roundtrip('ChoEmptyRoot', {int,0}),
- roundtrip('ChoEmptyRoot', {int,7}),
-
ok.