diff options
| author | Björn Gustavsson <[email protected]> | 2019-05-20 11:54:22 +0200 |
|---|---|---|
| committer | Björn Gustavsson <[email protected]> | 2019-05-20 13:22:55 +0200 |
| commit | cabdef3b97c077119fe6f43538dbdd5cffe9dd91 (patch) | |
| tree | 87a6fe405f4d1d6f7f4e0f0db3ea4dd34688e9bb /lib/compiler/test/beam_type_SUITE.erl | |
| parent | 6618ce7b6a621e92db72ea4f01f7d38553c8818c (diff) | |
| download | otp-cabdef3b97c077119fe6f43538dbdd5cffe9dd91.tar.gz otp-cabdef3b97c077119fe6f43538dbdd5cffe9dd91.tar.bz2 otp-cabdef3b97c077119fe6f43538dbdd5cffe9dd91.zip | |
Fix non-terminating compilation
The compiler would not terminate while compiling the following code:
foo(<<N:32>>, Tuple, NewValue) ->
_ = element(N, Tuple),
setelement(N, Tuple, NewValue).
The type analysis pass would attempt to construct a huge list when
attempting analyse the type of `Tuple` after the call to
`setelement/3`.
https://bugs.erlang.org/browse/ERL-948
Diffstat (limited to 'lib/compiler/test/beam_type_SUITE.erl')
| -rw-r--r-- | lib/compiler/test/beam_type_SUITE.erl | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/lib/compiler/test/beam_type_SUITE.erl b/lib/compiler/test/beam_type_SUITE.erl index 882e281a44..0d1680fb15 100644 --- a/lib/compiler/test/beam_type_SUITE.erl +++ b/lib/compiler/test/beam_type_SUITE.erl @@ -271,8 +271,22 @@ setelement(_Config) -> T0 = id({a,42}), {a,_} = T0, {b,_} = setelement(1, T0, b), + {z,b} = do_setelement_1(<<(id(1)):32>>, {a,b}, z), + {new,two} = do_setelement_2(<<(id(1)):1>>, {one,two}, new), ok. +do_setelement_1(<<N:32>>, Tuple, NewValue) -> + _ = element(N, Tuple), + %% While updating the type for Tuple, beam_ssa_type would do: + %% maps:without(lists:seq(0, 4294967295), Elements) + setelement(N, Tuple, NewValue). + +do_setelement_2(<<N:1>>, Tuple, NewValue) -> + %% Cover the second clause in remove_element_info/2. The + %% type for the second element will be kept. + two = element(2, Tuple), + setelement(N, Tuple, NewValue). + cons(_Config) -> [did] = cons(assigned, did), |