Merge branch 'bjorn/compiler/beam_validator'

* bjorn/compiler/beam_validator:
  beam_validator: Exit immediately on crashes
  beam_validator: Remove the file/1 and files/1 functions
  beam_validator: Remove support for all other unsupported instructions
  beam_validator: Remove support for unsupported bit syntax instructions

15 files changed, 36 insertions, 160 deletions

diff --git a/lib/compiler/test/beam_validator_SUITE_data/bad_dsetel.S b/lib/compiler/test/beam_validator_SUITE_data/bad_dsetel.S
index 279b2fa97f..9630d73a93 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/bad_dsetel.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/bad_dsetel.S
@@ -1,4 +1,4 @@
-{module, t}.  %% version = 0
+{module, bad_dsetel}.  %% version = 0
 
 {exports, [{module_info,0},{module_info,1},{t,1}]}.
 
@@ -21,7 +21,9 @@
     {move,{integer,3},{x,0}}.
     {call_ext,3,{extfunc,erlang,setelement,3}}.
     {test_heap,6,1}.
-    {put_string,3,{string,"abc"},{x,1}}.
+    {put_list,{integer,99},nil,{x,1}}.
+    {put_list,{integer,98},{x,1},{x,1}}.
+    {put_list,{integer,97},{x,1},{x,1}}.
     {set_tuple_element,{x,1},{x,0},1}.
     {'%live',1}.
     {deallocate,0}.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/bin_aligned.S b/lib/compiler/test/beam_validator_SUITE_data/bin_aligned.S
index 2f353fbd25..a59f7ccc03 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/bin_aligned.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/bin_aligned.S
@@ -1,4 +1,4 @@
-{module, t}.  %% version = 0
+{module, bin_aligned}.  %% version = 0
 
 {exports, [{decode,1},{module_info,0},{module_info,1}]}.
 
diff --git a/lib/compiler/test/beam_validator_SUITE_data/bin_match.S b/lib/compiler/test/beam_validator_SUITE_data/bin_match.S
deleted file mode 100644
index 96df0f7933..0000000000
--- a/lib/compiler/test/beam_validator_SUITE_data/bin_match.S
+++ /dev/null
@@ -1,64 +0,0 @@
-{module, bin_match}.  %% version = 0
-
-{exports, [{t,1}]}.
-
-{attributes, []}.
-
-{labels, 8}.
-
-
-{function, t, 1, 2}.
-  {label,1}.
-    {func_info,{atom,t},{atom,t},1}.
-  {label,2}.
-%%    {test,bs_start_match,{f,1},[{x,0}]}.
-    {bs_save,0}.
-    {test,bs_get_integer,
-          {f,3},
-          [{integer,8},1,{field_flags,[aligned,unsigned,big]},{x,1}]}.
-    {test,bs_get_integer,
-          {f,3},
-          [{integer,8},1,{field_flags,[aligned,unsigned,big]},{x,2}]}.
-    {test,bs_test_tail,{f,3},[0]}.
-    {test_heap,3,3}.
-    {put_tuple,2,{x,0}}.
-    {put,{x,1}}.
-    {put,{x,2}}.
-    {'%live',1}.
-    return.
-  {label,3}.
-    {bs_restore,0}.
-    {test,bs_get_integer,
-          {f,1},
-          [{integer,32},1,{field_flags,[aligned,unsigned,big]},{x,1}]}.
-    {test,bs_test_tail,{f,1},[0]}.
-    {move,{x,1},{x,0}}.
-    return.
-
-{function, x, 1, 5}.
-  {label,4}.
-    {func_info,{atom,t},{atom,x},1}.
-  {label,5}.
-    {test,bs_start_match,{f,4},[{x,0}]}.
-    {bs_save,0}.
-    {test,bs_get_integer,
-          {f,6},
-          [{integer,8},1,{field_flags,[aligned,unsigned,big]},{x,1}]}.
-    {test,bs_get_integer,
-          {f,6},
-          [{integer,8},1,{field_flags,[aligned,unsigned,big]},{x,2}]}.
-    {test,bs_test_tail,{f,6},[0]}.
-    {test_heap,3,3}.
-    {put_tuple,2,{x,0}}.
-    {put,{x,1}}.
-    {put,{x,2}}.
-    {'%live',1}.
-    return.
-  {label,6}.
-    {bs_restore,1}.
-    {test,bs_get_integer,
-          {f,4},
-          [{integer,32},1,{field_flags,[aligned,unsigned,big]},{x,1}]}.
-    {test,bs_test_tail,{f,4},[0]}.
-    {move,{x,1},{x,0}}.
-    return.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/dead_code.S b/lib/compiler/test/beam_validator_SUITE_data/dead_code.S
index f964f98fba..c114664ba0 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/dead_code.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/dead_code.S
@@ -1,10 +1,10 @@
 {module, dead_code}.  %% version = 0
 
-{exports, [{execute,0},{module_info,0},{module_info,1}]}.
+{exports, [{execute,0}]}.
 
 {attributes, []}.
 
-{labels, 10}.
+{labels, 6}.
 
 
 {function, execute, 0, 2}.
@@ -12,7 +12,6 @@
     {func_info,{atom,dead_code},{atom,execute},0}.
   {label,2}.
     {allocate,0,0}.
-    {'%live',0}.
     {call_ext,0,{extfunc,foo,fie,0}}.
     {test,is_ne,{f,4},[{x,0},{integer,0}]}.
     {test,is_ne,{f,4},[{x,0},{integer,1}]}.
@@ -22,27 +21,7 @@
     {case_end,{x,0}}.
   {label,4}.
     {move,{atom,ok},{x,0}}.
-    {'%live',1}.
     {deallocate,0}.
     return.
-    {'%','Moved code'}.
   {label,5}.
     {case_end,{x,0}}.
-
-
-{function, module_info, 0, 7}.
-  {label,6}.
-    {func_info,{atom,dead_code},{atom,module_info},0}.
-  {label,7}.
-    {move,nil,{x,0}}.
-    {'%live',1}.
-    return.
-
-
-{function, module_info, 1, 9}.
-  {label,8}.
-    {func_info,{atom,dead_code},{atom,module_info},1}.
-  {label,9}.
-    {move,nil,{x,0}}.
-    {'%live',1}.
-    return.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/erl_prim_loader.beam b/lib/compiler/test/beam_validator_SUITE_data/erl_prim_loader.beam
deleted file mode 100644
index dd58a88e42..0000000000
--- a/lib/compiler/test/beam_validator_SUITE_data/erl_prim_loader.beam
+++ /dev/null
diff --git a/lib/compiler/test/beam_validator_SUITE_data/freg_range.S b/lib/compiler/test/beam_validator_SUITE_data/freg_range.S
index ee583a923e..b3ebff3ade 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/freg_range.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/freg_range.S
@@ -1,10 +1,10 @@
 {module, freg_range}.  %% version = 0
 
-{exports, [{module_info,0},{module_info,1},{prod,2},{sum,2},{sum_prod,3}]}.
+{exports, [{sum_1,2},{sum_2,2},{sum_3,2},{sum_4,2}]}.
 
 {attributes, []}.
 
-{labels, 8}.
+{labels, 9}.
 
 
 {function, sum_1, 2, 2}.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/freg_state.S b/lib/compiler/test/beam_validator_SUITE_data/freg_state.S
index ff4d7548ae..7466763482 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/freg_state.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/freg_state.S
@@ -1,6 +1,6 @@
 {module, freg_state}.  %% version = 0
 
-{exports, []}.
+{exports, [{sum_1,2},{sum_2,2},{sum_3,2},{sum_4,2},{sum_5,2}]}.
 
 {attributes, []}.
 
diff --git a/lib/compiler/test/beam_validator_SUITE_data/freg_uninit.S b/lib/compiler/test/beam_validator_SUITE_data/freg_uninit.S
index f8d805d9ec..71e833446a 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/freg_uninit.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/freg_uninit.S
@@ -1,10 +1,10 @@
 {module, freg_uninit}.  %% version = 0
 
-{exports, []}.
+{exports, [{sum_1,2},{sum_2,2}]}.
 
 {attributes, []}.
 
-{labels, 8}.
+{labels, 7}.
 
 
 {function, sum_1, 2, 2}.
@@ -14,7 +14,6 @@
     {fconv,{x,0},{fr,0}}.
     fclearerror.
     {bif,fadd,{f,0},[{fr,0},{fr,1}],{fr,0}}.
-    {'%live',1}.
     return.
 
 
@@ -26,7 +25,12 @@
     {fconv,{x,1},{fr,1}}.
     fclearerror.
     {fcheckerror,{f,0}}.
-    {call,2,{f,8}}.
+    {call,2,{f,6}}.
     {bif,fadd,{f,0},[{fr,0},{fr,1}],{fr,0}}.
-    {'%live',1}.
+    return.
+
+{function, foo, 2, 6}.
+  {label,5}.
+    {func_info,{atom,t},{atom,foo},2}.
+  {label,6}.
     return.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/illegal_instruction.S b/lib/compiler/test/beam_validator_SUITE_data/illegal_instruction.S
deleted file mode 100644
index d6e92abc71..0000000000
--- a/lib/compiler/test/beam_validator_SUITE_data/illegal_instruction.S
+++ /dev/null
@@ -1,26 +0,0 @@
-{module, illegal_instruction}.  %% version = 0
-
-{exports, []}.
-
-{attributes, []}.
-
-{labels, 7}.
-
-
-{function, t, 1, 2}.
-  {label,1}.
-    {func_info,{atom,illegal_instruction},{atom,t},1}.
-  {label,2}.
-    {my_illegal_instruction,{x,0}}.
-    return.
-
-
-{function, x, 1, 4}.
-  {label,3}.
-    bad_func_info.
-  {label,4}.
-    {my_illegal_instruction,{x,0}}.
-    return.
-
-{function, y, 0, 17}.
-	
\ No newline at end of file
diff --git a/lib/compiler/test/beam_validator_SUITE_data/merge_undefined.S b/lib/compiler/test/beam_validator_SUITE_data/merge_undefined.S
index 3d76127824..481d55045d 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/merge_undefined.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/merge_undefined.S
@@ -22,7 +22,8 @@
   {label,4}.
     {allocate_heap,1,6,2}.
     {move,{x,1},{y,0}}.
-    {put_string,2,{string,"~p"},{x,0}}.
+    {put_list,{integer,112},nil,{x,0}}.
+    {put_list,{integer,126},{x,0},{x,0}}.
     {put_list,{y,0},nil,{x,1}}.
     {'%live',2}.
     {call_ext,2,{extfunc,io,format,2}}.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/no_exception_in_catch.S b/lib/compiler/test/beam_validator_SUITE_data/no_exception_in_catch.S
index e08a718a39..1a5b417a5f 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/no_exception_in_catch.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/no_exception_in_catch.S
@@ -26,7 +26,7 @@
     {call_ext,1,{extfunc,erlang,erase,1}}.
     {move,{atom,nested},{x,0}}.
     {call_ext,1,{extfunc,erlang,erase,1}}.
-    {bif,self,nofail,[],{x,0}}.
+    {bif,self,{f,0},[],{x,0}}.
     {'try',{y,8},{f,13}}.
     {'try',{y,7},{f,11}}.
     {'try',{y,6},{f,9}}.
@@ -34,7 +34,7 @@
 %% Because the following instructions can't possible throw an exception,
 %% label 7 used to get no state. Now the try_end itself will save the state.
     {move,{x,0},{y,4}}.
-    {bif,self,nofail,[],{x,0}}.
+    {bif,self,{f,0},[],{x,0}}.
     {'%live',1}.
     {try_end,{y,5}}.
     {test,is_eq_exact,{f,15},[{x,0},{y,4}]}.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/stack.S b/lib/compiler/test/beam_validator_SUITE_data/stack.S
index 244c22a2f9..e4356a9d00 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/stack.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/stack.S
@@ -1,10 +1,10 @@
 {module, stack}.  %% version = 0
 
-{exports, [{a,2},{b,2},{c,2},{d,2},{e,2}]}.
+{exports, [{a,2},{b,2},{c,2},{d,2},{e,2},{bad_1,0},{bad_2,0},{foo,0}]}.
 
 {attributes, []}.
 
-{labels, 21}.
+{labels, 17}.
 
 
 {function, a, 2, 2}.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/undef_label.S b/lib/compiler/test/beam_validator_SUITE_data/undef_label.S
deleted file mode 100644
index dd29066bf4..0000000000
--- a/lib/compiler/test/beam_validator_SUITE_data/undef_label.S
+++ /dev/null
@@ -1,22 +0,0 @@
-{module, undef_label}.  %% version = 0
-
-{exports, []}.
-
-{attributes, []}.
-
-{labels, 7}.
-
-
-{function, t, 1, 2}.
-  {label,1}.
-    {func_info,{atom,undef_label},{atom,t},1}.
-  {label,2}.
-    {test,is_eq_exact,{f,42},[{x,0},{atom,x}]}.
-    {move,{atom,ok},{x,0}}.
-    return.
-
-{function, x, 1, 17}.
-  {label,3}.
-    {func_info,{atom,undef_label},{atom,x},1}.
-  {label,4}.
-    return.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/uninit.S b/lib/compiler/test/beam_validator_SUITE_data/uninit.S
index 1a45c31411..9a66f4f7d6 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/uninit.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/uninit.S
@@ -1,9 +1,11 @@
 {module, uninit}.  %% version = 0
 
-{exports, []}.
+{exports, [{sum_1,2},{sum_2,2},{sum_3,2}]}.
 
 {attributes, []}.
 
+{labels, 9}.
+
 {function, sum_1, 2, 2}.
   {label,1}.
     {func_info,{atom,t},{atom,sum_1},2}.
@@ -11,7 +13,7 @@
     {allocate,1,2}.
     {move,{y,0},{x,0}}.
     {'%live',1}.
-    {call,1,{f,10}}.
+    {call,1,{f,8}}.
     {bif,'+',{f,0},[{x,0},{y,0}],{x,0}}.
     {'%live',1}.
     {deallocate,1}.
@@ -23,7 +25,7 @@
   {label,4}.
     {allocate,1,2}.
     {'%live',1}.
-    {call,1,{f,10}}.
+    {call,1,{f,8}}.
     {bif,'+',{f,0},[{x,0},{y,0}],{x,0}}.
     {'%live',1}.
     {deallocate,1}.
@@ -35,14 +37,14 @@
   {label,6}.
     {allocate_zero,1,2}.
     {'%live',1}.
-    {call,1,{f,10}}.
+    {call,1,{f,8}}.
     {bif,'+',{f,0},[{x,0},{y,0}],{x,0}}.
     {'%live',1}.
     {deallocate,1}.
     return.
 
-{function, id, 1, 10}.
-  {label,9}.
+{function, id, 1, 8}.
+  {label,7}.
     {func_info,{atom,t},{atom,id},1}.
-  {label,10}.
+  {label,8}.
     return.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/xrange.S b/lib/compiler/test/beam_validator_SUITE_data/xrange.S
index 3abbdffbc2..c6f20288f7 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/xrange.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/xrange.S
@@ -1,10 +1,10 @@
 {module, xrange}.  %% version = 0
 
-{exports, [{module_info,0},{module_info,1},{prod,2},{sum,2},{sum_prod,3}]}.
+{exports, [{sum_1,2},{sum_2,2},{sum_3,2},{sum_4,2}]}.
 
 {attributes, []}.
 
-{labels, 8}.
+{labels, 9}.
 
 
 {function, sum_1, 2, 2}.