Merge branch 'bjorn/compiler/misc'

* bjorn/compiler/misc:
  test_lib: Simplify uniq/0
  beam_dict: Correct comparison in opcode/2
  beam_utils: Re-use the local helper function drop_labels/1
  beam_asm: Speed up encoding of large numbers
  compilation_SUITE: Speed up the self_compile test cases
  beam_listing: Optimize writing of .S files
  v3_core, v3_codegen: Eliminate old-style catches
  cerl_inline: Replace old-style 'catch' with 'try'...'catch'
  sys_core_fold: Suppress warnings better
  beam_utils: Teach check_liveness/3 to understand get_map_elements
  Teach beam_trim to handle map instructions
  beam_utils: Be less conservative about liveness for exit instructions
  beam_validator: Stop validating the 'aligned' flag for binaries
  beam_validator: Clean up updating of types for y register
  beam_validator: Remove support for removed BIF fault/1,2
  beam_validator: Correct merging of states
  beam_validator: Correct merging of y registers
  sys_pre_expand: Remove unused fields in #expand{} record

1 files changed, 22 insertions, 33 deletions

diff --git a/lib/compiler/test/compilation_SUITE.erl b/lib/compiler/test/compilation_SUITE.erl
index 51e1da2cb6..f570d94f7d 100644
--- a/lib/compiler/test/compilation_SUITE.erl
+++ b/lib/compiler/test/compilation_SUITE.erl
@@ -428,41 +428,35 @@ self_compile_old_inliner(Config) when is_list(Config) ->
     self_compile_1(Config, "old", [verbose,{inline,500}]).
 
 self_compile_1(Config, Prefix, Opts) ->
-    ?line Dog = test_server:timetrap(test_server:minutes(40)),
+    Dog = test_server:timetrap(test_server:minutes(40)),
 
-    ?line Priv = ?config(priv_dir,Config),
-    ?line Version = compiler_version(),
+    Priv = ?config(priv_dir,Config),
+    Version = compiler_version(),
 
     %% Compile the compiler. (In this node to get better coverage.)
-    ?line CompA = make_compiler_dir(Priv, Prefix++"compiler_a"),
-    ?line VsnA = Version ++ ".0",
+    CompA = make_compiler_dir(Priv, Prefix++"compiler_a"),
+    VsnA = Version ++ ".0",
     compile_compiler(compiler_src(), CompA, VsnA, [clint0,clint|Opts]),
 
     %% Compile the compiler again using the newly compiled compiler.
     %% (In another node because reloading the compiler would disturb cover.)
     CompilerB = Prefix++"compiler_b",
     CompB = make_compiler_dir(Priv, CompilerB),
-    ?line VsnB = VsnA ++ ".0",
+    VsnB = VsnA ++ ".0",
     self_compile_node(CompA, CompB, VsnB, Opts),
 
-    %% Compare compiler directories.
-    ?line compare_compilers(CompA, CompB),
+    %% Compare compiler directories. The compiler directories should
+    %% be equal (except for beam_asm that contains the compiler version).
+    compare_compilers(CompA, CompB),
 
-    %% Compile and compare compiler C.
-    ?line CompilerC = Prefix++"compiler_c",
-    ?line CompC = make_compiler_dir(Priv, CompilerC),
-    ?line VsnC = VsnB ++ ".0",
-    self_compile_node(CompB, CompC, VsnC, Opts),
-    ?line compare_compilers(CompB, CompC),
-
-    ?line test_server:timetrap_cancel(Dog),
+    test_server:timetrap_cancel(Dog),
     ok.
 
 self_compile_node(CompilerDir, OutDir, Version, Opts) ->
-    ?line Dog = test_server:timetrap(test_server:minutes(15)),
-    ?line Pa = "-pa " ++ filename:dirname(code:which(?MODULE)) ++
+    Dog = test_server:timetrap(test_server:minutes(15)),
+    Pa = "-pa " ++ filename:dirname(code:which(?MODULE)) ++
 	" -pa " ++ CompilerDir,
-    ?line Files = compiler_src(),
+    Files = compiler_src(),
 
     %% We don't want the cover server started on the other node,
     %% because it will load the same cover-compiled code as on this
@@ -472,7 +466,7 @@ self_compile_node(CompilerDir, OutDir, Version, Opts) ->
        fun() ->
 	       compile_compiler(Files, OutDir, Version, Opts)
        end, Pa),
-    ?line test_server:timetrap_cancel(Dog),
+    test_server:timetrap_cancel(Dog),
     ok.
 
 compile_compiler(Files, OutDir, Version, InlineOpts) ->
@@ -499,27 +493,22 @@ compiler_modules(Dir) ->
     [list_to_atom(filename:rootname(filename:basename(F))) || F <- Files].
 
 make_compiler_dir(Priv, Dir0) ->
-    ?line Dir = filename:join(Priv, Dir0),
-    ?line ok = file:make_dir(Dir),
+    Dir = filename:join(Priv, Dir0),
+    ok = file:make_dir(Dir),
     Dir.
 
-make_current(Dir) ->    
-    true = code:add_patha(Dir),
-    lists:foreach(fun(File) ->
-			  c:l(File)
-		  end, compiler_modules(Dir)),
-    io:format("~p\n", [code:which(compile)]).
-
 compiler_version() ->
-    {value,{version,Version}} = lists:keysearch(version, 1,
-						compile:module_info(compile)),
+    {version,Version} = lists:keyfind(version, 1,
+				      compile:module_info(compile)),
     Version.
 
 compare_compilers(ADir, BDir) ->
     {[],[],D} = beam_lib:cmp_dirs(ADir, BDir),
-    [] = [T || {A,_}=T <- D,
-	       filename:basename(A) =/= "beam_asm.beam"]. %Contains compiler version.
 
+    %% beam_asm.beam contains compiler version and therefore it *must*
+    %% compare unequal.
+    ["beam_asm.beam"] = [filename:basename(A) || {A,_} <- D],
+    ok.
 
 %%%
 %%% The only test of the following code is that it compiles.