diff options
| author | Björn Gustavsson <[email protected]> | 2019-06-27 12:35:58 +0200 |
|---|---|---|
| committer | GitHub <[email protected]> | 2019-06-27 12:35:58 +0200 |
| commit | 4be7ac22d77680cf36302b3d6f37c5fe4cac7f2a (patch) | |
| tree | 589da73a0c4f542bcecb25ab4c2321850c94c3b1 /lib/compiler | |
| parent | aabe0523708ff131cd46f10a93aa3458a4125bdf (diff) | |
| parent | 48cdb47946c516579e6b46979ab4e6f9378d2e79 (diff) | |
| download | otp-4be7ac22d77680cf36302b3d6f37c5fe4cac7f2a.tar.gz otp-4be7ac22d77680cf36302b3d6f37c5fe4cac7f2a.tar.bz2 otp-4be7ac22d77680cf36302b3d6f37c5fe4cac7f2a.zip | |
Merge pull request #2305 from bjorng/bjorn/compiler/fix-slow-compilation/OTP-15923
Fix slow compilation of huge functions
Diffstat (limited to 'lib/compiler')
| -rw-r--r-- | lib/compiler/src/beam_ssa.erl | 20 |
1 files changed, 13 insertions, 7 deletions
diff --git a/lib/compiler/src/beam_ssa.erl b/lib/compiler/src/beam_ssa.erl index afd38dcd08..6492d1e1bf 100644 --- a/lib/compiler/src/beam_ssa.erl +++ b/lib/compiler/src/beam_ssa.erl @@ -123,7 +123,7 @@ 'copy' | 'put_tuple_arity' | 'put_tuple_element' | 'put_tuple_elements' | 'set_tuple_element'. --import(lists, [foldl/3,keyfind/3,mapfoldl/3,member/2,reverse/1]). +-import(lists, [foldl/3,keyfind/3,mapfoldl/3,member/2,reverse/1,umerge/1]). -spec add_anno(Key, Value, Construct) -> Construct when Key :: atom(), @@ -651,12 +651,18 @@ is_commutative('=/=') -> true; is_commutative('/=') -> true; is_commutative(_) -> false. -def_used_1([#b_blk{is=Is,last=Last}|Bs], Preds, Def0, Used0) -> - {Def,Used1} = def_used_is(Is, Preds, Def0, Used0), - Used = ordsets:union(used(Last), Used1), - def_used_1(Bs, Preds, Def, Used); -def_used_1([], _Preds, Def, Used) -> - {ordsets:from_list(Def),Used}. +def_used_1([#b_blk{is=Is,last=Last}|Bs], Preds, Def0, UsedAcc) -> + {Def,Used} = def_used_is(Is, Preds, Def0, used(Last)), + case Used of + [] -> + def_used_1(Bs, Preds, Def, UsedAcc); + [_|_] -> + def_used_1(Bs, Preds, Def, [Used|UsedAcc]) + end; +def_used_1([], _Preds, Def0, UsedAcc) -> + Def = ordsets:from_list(Def0), + Used = umerge(UsedAcc), + {Def,Used}. def_used_is([#b_set{op=phi,dst=Dst,args=Args}|Is], Preds, Def0, Used0) -> |