Merge branch 'hasse/dialyzer/prettier_warnings/OTP-15135'

* hasse/dialyzer/prettier_warnings/OTP-15135:
  dialyzer: Remove quotes around operators
  dialyzer: Add test cases with indentation
  dialyzer: Add an --no_indentation option
  dialyzer: Add parentheses around annotated union elements
  dialyzer: Fix dialyzer_dataflow:format_args_1()

3 files changed, 64 insertions, 0 deletions

diff --git a/lib/dialyzer/test/indent2_SUITE_data/results/arr b/lib/dialyzer/test/indent2_SUITE_data/results/arr
new file mode 100644
index 0000000000..77e67f0cab
--- /dev/null
+++ b/lib/dialyzer/test/indent2_SUITE_data/results/arr
@@ -0,0 +1,15 @@
+
+arr.erl:14: Type specification arr:test2
+          (array:array(T), non_neg_integer(), T) -> array:array(T) is a supertype of the success typing: arr:test2
+          (array:array(_), pos_integer(), _) -> array:array(_)
+arr.erl:24: Type specification arr:test4
+          (array:array(T), non_neg_integer(), _) -> array:array(T) is a supertype of the success typing: arr:test4
+          (array:array(_), pos_integer(), _) -> array:array(_)
+arr.erl:29: Type specification arr:test5
+          (array:array(T), non_neg_integer(), T) -> array:array(T) is a supertype of the success typing: arr:test5
+          (array:array(_), non_neg_integer(), integer()) ->
+             array:array(_)
+arr.erl:37: Type specification arr:test6
+          (array:array(integer()), non_neg_integer(), integer()) ->
+             array:array(any()) is not equal to the success typing: arr:test6
+          (array:array(_), non_neg_integer(), _) -> array:array(_)
diff --git a/lib/dialyzer/test/indent2_SUITE_data/results/iodata b/lib/dialyzer/test/indent2_SUITE_data/results/iodata
new file mode 100644
index 0000000000..d95551d330
--- /dev/null
+++ b/lib/dialyzer/test/indent2_SUITE_data/results/iodata
@@ -0,0 +1,24 @@
+
+iodata.erl:7: The specification for iodata:encode/2 states that the function might also return 
+          binary() but the inferred return is 
+          nonempty_maybe_improper_list(<<_:8, _:_*8>> |
+                                       nonempty_maybe_improper_list(<<_:8,
+                                                                      _:_*8>> |
+                                                                    nonempty_maybe_improper_list(any(),
+                                                                                                 <<_:8,
+                                                                                                   _:_*8>> |
+                                                                                                 []) |
+                                                                    byte(),
+                                                                    <<_:8,
+                                                                      _:_*8>> |
+                                                                    []) |
+                                       integer(),
+                                       <<_:8, _:_*8>> | []) |
+          integer()
+iodata.erl:7: The success typing for iodata:encode/2 implies that the function might also return 
+          integer() but the specification return is 
+          binary() |
+          maybe_improper_list(binary() |
+                              maybe_improper_list(any(), binary() | []) |
+                              byte(),
+                              binary() | [])
diff --git a/lib/dialyzer/test/indent2_SUITE_data/results/remote b/lib/dialyzer/test/indent2_SUITE_data/results/remote
new file mode 100644
index 0000000000..6decec6c6a
--- /dev/null
+++ b/lib/dialyzer/test/indent2_SUITE_data/results/remote
@@ -0,0 +1,25 @@
+
+remotes1.erl:17: The specification for remotes1:foo5/1 states that the function might also return 
+          'ko' but the inferred return is 
+          'ok'
+remotes1.erl:20: Type specification remotes1:foo6
+          ('ok' | 'ko') -> 'ok' is a supertype of the success typing: remotes1:foo6
+          ('ok') -> 'ok'
+remotes1.erl:25: The specification for remotes1:foo7/1 states that the function might also return 
+          'ko' but the inferred return is 
+          'ok'
+remotes1.erl:28: Type specification remotes1:foo8
+          (local_type_42()) -> 'ok' is a supertype of the success typing: remotes1:foo8
+          ('ok') -> 'ok'
+remotes1.erl:33: The specification for remotes1:foo9/1 states that the function might also return 
+          'ko' but the inferred return is 
+          'ok'
+remotes1.erl:36: Type specification remotes1:foo10
+          (local_and_known_remote_type_42()) -> 'ok' is a supertype of the success typing: remotes1:foo10
+          ('ok') -> 'ok'
+remotes1.erl:49: Type specification remotes1:foo13
+          ('ok') -> local_and_unknown_remote_type_42() is a supertype of the success typing: remotes1:foo13
+          ('ok') -> 'ok'
+remotes1.erl:52: Type specification remotes1:foo14
+          (local_and_unknown_remote_type_42()) -> 'ok' is a supertype of the success typing: remotes1:foo14
+          ('ok') -> 'ok'