diff options
author | Magnus Lång <[email protected]> | 2016-03-01 12:51:16 +0100 |
---|---|---|
committer | Hans Bolinder <[email protected]> | 2016-04-28 16:16:10 +0200 |
commit | 67c7fd3c516b08d3d8814debca0db2a295e0c0b8 (patch) | |
tree | f4b1cc958870dcbf381a1fb08ae34f07e149c29d /lib/dialyzer/test/map_SUITE_data/src/contract_violation.erl | |
parent | 50054b94fee69fd39af32b4161d005588ed5f22f (diff) | |
download | otp-67c7fd3c516b08d3d8814debca0db2a295e0c0b8.tar.gz otp-67c7fd3c516b08d3d8814debca0db2a295e0c0b8.tar.bz2 otp-67c7fd3c516b08d3d8814debca0db2a295e0c0b8.zip |
dialyzer_contracts: Consider #{} a violation
This is analogous to the case of nil. Since #{} is a base-case of almost
all map types, contract and success typing sharing #{} does not mean
much, and is often sign of a violation.
Diffstat (limited to 'lib/dialyzer/test/map_SUITE_data/src/contract_violation.erl')
-rw-r--r-- | lib/dialyzer/test/map_SUITE_data/src/contract_violation.erl | 29 |
1 files changed, 29 insertions, 0 deletions
diff --git a/lib/dialyzer/test/map_SUITE_data/src/contract_violation.erl b/lib/dialyzer/test/map_SUITE_data/src/contract_violation.erl new file mode 100644 index 0000000000..850f2cad34 --- /dev/null +++ b/lib/dialyzer/test/map_SUITE_data/src/contract_violation.erl @@ -0,0 +1,29 @@ +-module(contract_violation). + +-export([entry/1, beam_disasm_lines/2]). + +%%----------------------------------------------------------------------- + +-type lines() :: #{non_neg_integer() => {string(), non_neg_integer()}}. + +entry(Bin) -> + I = 42, + case beam_disasm_lines(Bin, ':-)') of + #{I := Loc} -> {good, Loc}; + _ -> bad + end. + +-spec beam_disasm_lines(binary() | none, module()) -> lines(). + +beam_disasm_lines(none, _) -> #{}; +beam_disasm_lines(<<NumLines:32, LineBin:NumLines/binary, FileBin/binary>>, + _Module) -> + Lines = binary_to_term(LineBin), + Files = binary_to_term(FileBin), + lines_collect_items(Lines, Files, #{}). + +lines_collect_items([], _, Acc) -> Acc; +lines_collect_items([{FileNo, LineNo}|Rest], Files, Acc) -> + #{FileNo := File} = Files, + lines_collect_items( + Rest, Files, Acc#{map_size(Acc)+1 => {location, File, LineNo}}). |