Merge branch 'hb/dialyzer/fix_opaque_types/OTP-12493'

* hb/dialyzer/fix_opaque_types/OTP-12493:
  dialyzer: Fix a minor bug concerning opaque types
  dialyzer: Modify warning for comparison of opaque types
  dialyzer: Modify the handling of parametrized opaque types

7 files changed, 318 insertions, 7 deletions

diff --git a/lib/dialyzer/test/opaque_SUITE_data/src/para/para2.erl b/lib/dialyzer/test/opaque_SUITE_data/src/para/para2.erl
index 09b2235fa5..4461ff291c 100644
--- a/lib/dialyzer/test/opaque_SUITE_data/src/para/para2.erl
+++ b/lib/dialyzer/test/opaque_SUITE_data/src/para/para2.erl
@@ -85,7 +85,7 @@ ct2_adt() ->
 tcirc() ->
     A = circ1(),
     B = circ2(),
-    A =:= B. % can never evaluate to 'true' (but the types are not OK, or?)
+    A =:= B. % can never evaluate to 'true'
 
 -spec circ1() -> circ(integer()).
 
@@ -100,7 +100,7 @@ circ2() ->
 tcirc_adt() ->
     A = circ1_adt(),
     B = circ2_adt(),
-    A =:= B. % opaque attempt (one would expect them to be the same...)
+    A =:= B. % opaque attempt (number of parameters differs)
 
 circ1_adt() ->
     para2_adt:circ1().
diff --git a/lib/dialyzer/test/opaque_SUITE_data/src/para/para3.erl b/lib/dialyzer/test/opaque_SUITE_data/src/para/para3.erl
index 792ae40d39..102215b28d 100644
--- a/lib/dialyzer/test/opaque_SUITE_data/src/para/para3.erl
+++ b/lib/dialyzer/test/opaque_SUITE_data/src/para/para3.erl
@@ -71,7 +71,7 @@ t2_adt() ->
 
 -type exp() :: para3_adt:exp1(para3_adt:exp2()).
 
--spec exp_adt() -> exp().
+-spec exp_adt() -> exp(). % invalid type spec
 
 exp_adt() ->
     3.
diff --git a/lib/dialyzer/test/opaque_SUITE_data/src/para/para4.erl b/lib/dialyzer/test/opaque_SUITE_data/src/para/para4.erl
new file mode 100644
index 0000000000..b9794672a9
--- /dev/null
+++ b/lib/dialyzer/test/opaque_SUITE_data/src/para/para4.erl
@@ -0,0 +1,134 @@
+-module(para4).
+
+-compile(export_all).
+
+-export_type([d_atom/0, d_integer/0, d_tuple/0, d_all/0]).
+
+-export_type([t/1]).
+
+-type ai() :: atom() | integer().
+
+-type d(T) :: dict:dict(T, T).
+
+-opaque d_atom() :: d(atom()).
+-opaque d_integer() :: d(integer()).
+-opaque d_tuple() :: d(tuple()).
+-opaque d_all() :: d(ai()).
+
+b(D) ->
+    a(D) ++ i(D).
+
+-spec a(d_atom()) -> [{atom(), atom()}]. % Invalid type spec
+
+a(D) ->
+    c(D).
+
+-spec i(d_integer()) -> [{integer(), integer()}]. % Invalid type spec
+
+i(D) ->
+    c(D).
+
+-spec t(d_tuple()) -> [{tuple(), tuple()}]. % Invalid type spec.
+
+t(D) ->
+    c(D).
+
+-spec c(d_all()) -> [{ai(), ai()}].
+
+c(D) ->
+    dict:to_list(D).
+
+
+
+
+-opaque t(A) :: {A, A}.
+
+adt_tt5() ->
+    I1 = adt_y1(),
+    I2 = adt_y3(),
+    I1 =:= I2.
+
+adt_tt6() ->
+    I1 = adt_y2(),
+    I2 = adt_y3(),
+    I1 =:= I2.
+
+adt_tt7() ->
+    I1 = adt_t1(),
+    I2 = adt_t3(),
+    I1 =:= I2. % opaque attempt
+
+adt_tt8() ->
+    I1 = adt_t2(),
+    I2 = adt_t3(),
+    I1 =:= I2. % opaque attempt
+
+adt_tt9() ->
+    I1 = adt_int2(),
+    I2 = adt_int4(),
+    I1 =:= I2. % opaque attempt
+
+adt_tt10() ->
+    I1 = adt_int2(),
+    I2 = adt_int2_4(),
+    I1 =:= I2. % opaque attempt
+
+adt_tt11() ->
+    I1 = adt_int5_7(),
+    I2 = adt_int2_4(),
+    I1 =:= I2. % opaque attempt
+
+adt_tt12() ->
+    I1 = adt_un1_2(),
+    I2 = adt_un3_4(),
+    I1 =:= I2. % opaque attempt
+
+adt_tt13() ->
+    I1 = adt_tup(),
+    I2 = adt_tup2(),
+    I1 =:= I2. % opaque attempt
+
+y3() ->
+    {a, 3}.
+
+adt_t1() ->
+    para4_adt:t1().
+
+adt_t2() ->
+    para4_adt:t2().
+
+adt_t3() ->
+    para4_adt:t3().
+
+adt_y1() ->
+    para4_adt:y1().
+
+adt_y2() ->
+    para4_adt:y2().
+
+adt_y3() ->
+    para4_adt:y3().
+
+adt_int2() ->
+    para4_adt:int2().
+
+adt_int4() ->
+    para4_adt:int4().
+
+adt_int2_4() ->
+    para4_adt:int2_4().
+
+adt_int5_7() ->
+    para4_adt:int5_7().
+
+adt_un1_2() ->
+    para4_adt:un1_2().
+
+adt_un3_4() ->
+    para4_adt:un3_4().
+
+adt_tup() ->
+    para4_adt:tup().
+
+adt_tup2() ->
+    para4_adt:tup2().
diff --git a/lib/dialyzer/test/opaque_SUITE_data/src/para/para4_adt.erl b/lib/dialyzer/test/opaque_SUITE_data/src/para/para4_adt.erl
new file mode 100644
index 0000000000..407dd198a7
--- /dev/null
+++ b/lib/dialyzer/test/opaque_SUITE_data/src/para/para4_adt.erl
@@ -0,0 +1,108 @@
+-module(para4_adt).
+
+-export([t1/0, t2/0, t3/0, y1/0, y2/0, y3/0]).
+
+-export([int2/0, int4/0, int2_4/0, int5_7/0]).
+
+-export([un1_2/0, un3_4/0]).
+
+-export([tup/0, tup2/0]).
+
+-export_type([t/1, y/1, int/1, tup/1, un/1]).
+
+-type ai() :: atom() | integer().
+
+-opaque t(A) :: {A, A}.
+
+-type y(A) :: {A, A}.
+
+-opaque int(I) :: I.
+
+-opaque un(I) :: atom() | I.
+
+-opaque tup(T) :: T.
+
+-spec t1() -> t(integer()).
+
+t1() ->
+    {i(), i()}.
+
+-spec t2() -> t(atom()).
+
+t2() ->
+    {a(), a()}.
+
+-spec t3() -> t(ai()).
+
+t3() ->
+    {ai(), ai()}.
+
+-spec y1() -> y(integer()).
+
+y1() ->
+    {i(), i()}.
+
+-spec y2() -> y(atom()).
+
+y2() ->
+    {a(), a()}.
+
+-spec y3() -> y(ai()).
+
+y3() ->
+    {ai(), ai()}.
+
+-spec a() -> atom().
+
+a() ->
+    foo:a().
+
+-spec i() -> integer().
+
+i() ->
+    foo:i().
+
+-spec ai() -> ai().
+
+ai() ->
+    foo:ai().
+
+-spec int2() -> int(1..2).
+
+int2() ->
+    foo:int2().
+
+-spec int4() -> int(1..4).
+
+int4() ->
+    foo:int4().
+
+-spec int2_4() -> int(2..4).
+
+int2_4() ->
+    foo:int2_4().
+
+-spec int5_7() -> int(5..7).
+
+int5_7() ->
+    foo:int5_7().
+
+-spec un1_2() -> un(1..2).
+
+un1_2() ->
+    foo:un1_2().
+
+-spec un3_4() -> un(3..4).
+
+un3_4() ->
+    foo:un3_4().
+
+-spec tup() -> tup(tuple()).
+
+tup() ->
+    foo:tup().
+
+-spec tup2() -> tup({_, _}).
+
+tup2() ->
+    foo:tup2().
diff --git a/lib/dialyzer/test/opaque_SUITE_data/src/para/para5.erl b/lib/dialyzer/test/opaque_SUITE_data/src/para/para5.erl
new file mode 100644
index 0000000000..76ea3e76b5
--- /dev/null
+++ b/lib/dialyzer/test/opaque_SUITE_data/src/para/para5.erl
@@ -0,0 +1,33 @@
+-module(para5).
+
+-export([d/0, dd/0, da1/0]).
+
+d() ->
+    I1 = adt_d1(),
+    I2 = adt_d2(),
+    I1 =:= I2. % can never evaluate to true
+
+dd() ->
+    I1 = adt_d1(),
+    I2 = adt_dd(),
+    I1 =/= I2. % incompatible opaque types
+
+da1() ->
+    I1 = adt_da1(),
+    I2 = adt_da2(),
+    I1 =:= I2.
+
+adt_d1() ->
+    para5_adt:d1().
+
+adt_d2() ->
+    para5_adt:d2().
+
+adt_dd() ->
+    para5_adt:dd().
+
+adt_da1() ->
+    para5_adt:da1().
+
+adt_da2() ->
+    para5_adt:da2().
diff --git a/lib/dialyzer/test/opaque_SUITE_data/src/para/para5_adt.erl b/lib/dialyzer/test/opaque_SUITE_data/src/para/para5_adt.erl
new file mode 100644
index 0000000000..a62e0488e0
--- /dev/null
+++ b/lib/dialyzer/test/opaque_SUITE_data/src/para/para5_adt.erl
@@ -0,0 +1,36 @@
+-module(para5_adt).
+
+-export([d1/0, d2/0, dd/0, da1/0, da2/0]).
+
+-export_type([d/0, dd/1, da/2]).
+
+-opaque d() :: 1 | 2.
+
+-spec d1() -> d().
+
+d1() ->
+    1.
+
+-spec d2() -> d().
+
+d2() ->
+    2.
+
+-opaque dd(A) :: A.
+
+-spec dd() -> dd(atom()).
+
+dd() ->
+    foo:atom().
+
+-opaque da(A, B) :: {A, B}.
+
+-spec da1() -> da(any(), atom()).
+
+da1() ->
+    {3, a}.
+
+-spec da2() -> da(integer(), any()).
+
+da2() ->
+    {3, a}.
diff --git a/lib/dialyzer/test/opaque_SUITE_data/src/simple/simple1_api.erl b/lib/dialyzer/test/opaque_SUITE_data/src/simple/simple1_api.erl
index eef2074e0c..7db1100597 100644
--- a/lib/dialyzer/test/opaque_SUITE_data/src/simple/simple1_api.erl
+++ b/lib/dialyzer/test/opaque_SUITE_data/src/simple/simple1_api.erl
@@ -145,7 +145,7 @@ adt_t4() ->
     A = simple1_adt:n1(),
     B = simple1_adt:n2(),
     A = A, % OK
-    A = B. % opaque term
+    A = B. % opaque terms
 
 adt_t7() ->
     A = simple1_adt:n1(),
@@ -178,7 +178,7 @@ c2(A, B) ->
 c2() ->
     A = simple1_adt:d1(),
     B = simple1_adt:d2(),
-    if A =< B -> ok end. % opaque term
+    if A =< B -> ok end. % opaque terms
 
 c3() ->
     B = simple1_adt:d2(),
@@ -516,7 +516,7 @@ eq1() ->
     A = simple1_adt:d2(),
     B = simple1_adt:d1(),
     if
-        A == B -> % opaque term
+        A == B -> % opaque terms
             0;
         A == A ->
             1;
@@ -555,7 +555,7 @@ c6(A, B) ->
 c7(A, B) ->
     A = simple1_adt:d1(),
     B = simple1_adt:d2(),
-    A =< B. % opaque term
+    A =< B. % opaque terms
 
 c8() ->
     D = digraph:new(),