inets,tftp: Break out TFTP from inets

- Create directory structure
- Move code, tests, documentation from inets
- Add inets_tftp_wrapper
- Add tftp app to run-dialyzer script

Change-Id: I6a142ae66cecb9a1821cbf9ea6a45f66a836763d

5 files changed, 57 insertions, 28 deletions

diff --git a/lib/inets/src/inets_app/Makefile b/lib/inets/src/inets_app/Makefile
index 450e49dcc3..fad2fefe2f 100644
--- a/lib/inets/src/inets_app/Makefile
+++ b/lib/inets/src/inets_app/Makefile
@@ -49,7 +49,8 @@ MODULES = \
 	inets_sup \
 	inets_trace \
 	inets_lib \
-	inets_ftp_wrapper
+	inets_ftp_wrapper \
+	inets_tftp_wrapper
 
 INTERNAL_HRL_FILES = inets_internal.hrl
 EXTERNAL_HRL_FILES = ../../include/httpd.hrl \
diff --git a/lib/inets/src/inets_app/inets.app.src b/lib/inets/src/inets_app/inets.app.src
index 0af44e39ab..dfe773e7fe 100644
--- a/lib/inets/src/inets_app/inets.app.src
+++ b/lib/inets/src/inets_app/inets.app.src
@@ -98,13 +98,7 @@
             mod_trace,
             
             %% TFTP
-            tftp,
-            tftp_binary,
-            tftp_engine,
-            tftp_file,
-            tftp_lib,
-            tftp_logger,
-            tftp_sup
+            inets_tftp_wrapper
         ]},
   {registered,[inets_sup, httpc_manager]},
   %% If the "new" ssl is used then 'crypto' must be started before inets.
diff --git a/lib/inets/src/inets_app/inets.erl b/lib/inets/src/inets_app/inets.erl
index 615a4cf635..9005e73f5d 100644
--- a/lib/inets/src/inets_app/inets.erl
+++ b/lib/inets/src/inets_app/inets.erl
@@ -465,11 +465,13 @@ call_service(Service, Call, Args) ->
         exit:{noproc, _} ->
             {error, inets_not_started}
     end.
-	
+
+%% Obsolete! Kept for backward compatiblity!
+%% TFTP application has been moved out from inets
 service_module(tftpd) ->
-    tftp;
+    inets_tftp_wrapper;
 service_module(tftpc) ->
-    tftp;
+    inets_tftp_wrapper;
 %% Obsolete! Kept for backward compatiblity!
 %% FTP application has been moved out from inets
 service_module(ftpc) ->
diff --git a/lib/inets/src/inets_app/inets_sup.erl b/lib/inets/src/inets_app/inets_sup.erl
index 8f4d806529..22c928f9f9 100644
--- a/lib/inets/src/inets_app/inets_sup.erl
+++ b/lib/inets/src/inets_app/inets_sup.erl
@@ -61,9 +61,7 @@ children() ->
     Services = get_services(),
     HttpdServices = [Service || Service <- Services, is_httpd(Service)],
     HttpcServices =  [Service || Service <- Services, is_httpc(Service)],
-    TftpdServices =  [Service || Service <- Services, is_tftpd(Service)],
-    [httpc_child_spec(HttpcServices),
-     httpd_child_spec(HttpdServices), tftpd_child_spec(TftpdServices)].
+    [httpc_child_spec(HttpcServices), httpd_child_spec(HttpdServices)].
 
 httpc_child_spec(HttpcServices0) ->
     HttpcServices = default_profile(HttpcServices0, []),
@@ -84,15 +82,6 @@ httpd_child_spec(HttpdServices) ->
     Type = supervisor,
     {Name, StartFunc, Restart, Shutdown, Type, Modules}.
 
-tftpd_child_spec(TftpServices) ->
-    Name = tftp_sup,
-    StartFunc = {tftp_sup, start_link, [TftpServices]},
-    Restart = permanent, 
-    Shutdown = infinity,
-    Modules = [tftp_sup],
-    Type = supervisor,
-    {Name, StartFunc, Restart, Shutdown, Type, Modules}.
-
 is_httpd({httpd, _}) ->
     true;
 is_httpd({httpd, _, _}) ->
@@ -105,11 +94,6 @@ is_httpc({httpc, _}) ->
 is_httpc(_) ->
     false.
 
-is_tftpd({tftpd, _}) ->
-    true;
-is_tftpd(_) ->
-    false.
-
 default_profile([], Acc) ->
     [{httpc, {default, only_session_cookies}} | Acc];
 default_profile([{httpc, {default, _}} | _] = Profiles, Acc) ->
diff --git a/lib/inets/src/inets_app/inets_tftp_wrapper.erl b/lib/inets/src/inets_app/inets_tftp_wrapper.erl
new file mode 100644
index 0000000000..1e5deb234b
--- /dev/null
+++ b/lib/inets/src/inets_app/inets_tftp_wrapper.erl
@@ -0,0 +1,48 @@
+%%
+%% %CopyrightBegin%
+%%
+%% Copyright Ericsson AB 2006-2018. All Rights Reserved.
+%%
+%% Licensed under the Apache License, Version 2.0 (the "License");
+%% you may not use this file except in compliance with the License.
+%% You may obtain a copy of the License at
+%%
+%%     http://www.apache.org/licenses/LICENSE-2.0
+%%
+%% Unless required by applicable law or agreed to in writing, software
+%% distributed under the License is distributed on an "AS IS" BASIS,
+%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+%% See the License for the specific language governing permissions and
+%% limitations under the License.
+%%
+%% %CopyrightEnd%
+%%
+-module(inets_tftp_wrapper).
+
+
+-export([start_standalone/1,
+         start_service/1,
+	 stop_service/1,
+	 services/0,
+         service_info/1]).
+
+
+start_standalone(Options) ->
+    tftp:start_standalone(Options).
+
+
+start_service(Options) ->
+    application:ensure_started(tftp),
+    tftp:start_service(Options).
+
+
+stop_service(Pid) ->
+    tftp:stop_service(Pid).
+
+
+services() ->
+    [].
+
+
+service_info(_) ->
+    [].