Merge tag 'OTP-19.0' into sverker/19/binary_to_atom-utf8-crash/ERL-474/OTP-14590

1 files changed, 205 insertions, 99 deletions

diff --git a/lib/jinterface/java_src/com/ericsson/otp/erlang/OtpSelf.java b/lib/jinterface/java_src/com/ericsson/otp/erlang/OtpSelf.java
index 8e78cda894..97f7f037e7 100644
--- a/lib/jinterface/java_src/com/ericsson/otp/erlang/OtpSelf.java
+++ b/lib/jinterface/java_src/com/ericsson/otp/erlang/OtpSelf.java
@@ -1,54 +1,53 @@
 /*
  * %CopyrightBegin%
- * 
- * Copyright Ericsson AB 2000-2009. All Rights Reserved.
- * 
- * The contents of this file are subject to the Erlang Public License,
- * Version 1.1, (the "License"); you may not use this file except in
- * compliance with the License. You should have received a copy of the
- * Erlang Public License along with this software. If not, it can be
- * retrieved online at http://www.erlang.org/.
- * 
- * Software distributed under the License is distributed on an "AS IS"
- * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
- * the License for the specific language governing rights and limitations
- * under the License.
- * 
+ *
+ * Copyright Ericsson AB 2000-2016. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
  * %CopyrightEnd%
  */
 package com.ericsson.otp.erlang;
 
 import java.io.IOException;
-import java.net.ServerSocket;
-import java.net.Socket;
 import java.net.UnknownHostException;
 
 /**
  * Represents an OTP node. It is used to connect to remote nodes or accept
  * incoming connections from remote nodes.
- * 
+ *
  * <p>
  * When the Java node will be connecting to a remote Erlang, Java or C node, it
  * must first identify itself as a node by creating an instance of this class,
  * after which it may connect to the remote node.
- * 
+ *
  * <p>
  * When you create an instance of this class, it will bind a socket to a port so
  * that incoming connections can be accepted. However the port number will not
  * be made available to other nodes wishing to connect until you explicitely
  * register with the port mapper daemon by calling {@link #publishPort()}.
  * </p>
- * 
+ *
  * <pre>
  * OtpSelf self = new OtpSelf(&quot;client&quot;, &quot;authcookie&quot;); // identify self
  * OtpPeer other = new OtpPeer(&quot;server&quot;); // identify peer
- * 
+ *
  * OtpConnection conn = self.connect(other); // connect to peer
  * </pre>
- * 
+ *
  */
 public class OtpSelf extends OtpLocalNode {
-    private final ServerSocket sock;
+    private final OtpServerTransport sock;
     private final OtpErlangPid pid;
 
     /**
@@ -58,47 +57,154 @@ public class OtpSelf extends OtpLocalNode {
      * directory. The home directory is obtained from the System property
      * "user.home".
      * </p>
-     * 
+     *
      * <p>
      * If the file does not exist, an empty string is used. This method makes no
      * attempt to create the file.
      * </p>
-     * 
+     *
      * @param node
-     *                the name of this node.
-     * 
+     *            the name of this node.
+     *
+     * @exception IOException
+     *                in case of server transport failure
+     *
      */
     public OtpSelf(final String node) throws IOException {
-	this(node, defaultCookie, 0);
+        this(node, defaultCookie, 0);
+    }
+
+    /**
+     * <p>
+     * Create a self node using the default cookie and custom transport factory.
+     * The default cookie is found by reading the first line of the
+     * .erlang.cookie file in the user's home directory. The home directory is
+     * obtained from the System property "user.home".
+     * </p>
+     *
+     * <p>
+     * If the file does not exist, an empty string is used. This method makes no
+     * attempt to create the file.
+     * </p>
+     *
+     * @param node
+     *            the name of this node.
+     *
+     * @param transportFactory
+     *            the transport factory to use when creating connections.
+     *
+     * @exception IOException
+     *                in case of server transport failure
+     *
+     */
+    public OtpSelf(final String node,
+            final OtpTransportFactory transportFactory) throws IOException {
+        this(node, defaultCookie, 0, transportFactory);
     }
 
     /**
      * Create a self node.
-     * 
+     *
      * @param node
-     *                the name of this node.
-     * 
+     *            the name of this node.
+     *
      * @param cookie
-     *                the authorization cookie that will be used by this node
-     *                when it communicates with other nodes.
+     *            the authorization cookie that will be used by this node when
+     *            it communicates with other nodes.
+     *
+     * @exception IOException
+     *                in case of server transport failure
      */
     public OtpSelf(final String node, final String cookie) throws IOException {
-	this(node, cookie, 0);
+        this(node, cookie, 0);
+    }
+
+    /**
+     * Create a self node.
+     *
+     * @param node
+     *            the name of this node.
+     *
+     * @param cookie
+     *            the authorization cookie that will be used by this node when
+     *            it communicates with other nodes.
+     *
+     * @param transportFactory
+     *            the transport factory to use when creating connections.
+     *
+     * @exception IOException
+     *                in case of server transport failure
+     */
+    public OtpSelf(final String node, final String cookie,
+            final OtpTransportFactory transportFactory) throws IOException {
+        this(node, cookie, 0, transportFactory);
     }
 
+    /**
+     * Create a self node.
+     *
+     * @param node
+     *            the name of this node.
+     *
+     * @param cookie
+     *            the authorization cookie that will be used by this node when
+     *            it communicates with other nodes.
+     *
+     * @param port
+     *            the port number you wish to use for incoming connections.
+     *            Specifying 0 lets the system choose an available port.
+     *
+     * @exception IOException
+     *                in case of server transport failure
+     */
     public OtpSelf(final String node, final String cookie, final int port)
-	    throws IOException {
-	super(node, cookie);
+            throws IOException {
+        super(node, cookie);
 
-	sock = new ServerSocket(port);
+        sock = createServerTransport(port);
 
-	if (port != 0) {
-	    this.port = port;
-	} else {
-	    this.port = sock.getLocalPort();
-	}
+        if (port != 0) {
+            this.port = port;
+        } else {
+            this.port = sock.getLocalPort();
+        }
 
-	pid = createPid();
+        pid = createPid();
+    }
+
+    /**
+     * Create a self node.
+     *
+     * @param node
+     *            the name of this node.
+     *
+     * @param cookie
+     *            the authorization cookie that will be used by this node when
+     *            it communicates with other nodes.
+     *
+     * @param port
+     *            the port number you wish to use for incoming connections.
+     *            Specifying 0 lets the system choose an available port.
+     *
+     * @param transportFactory
+     *            the transport factory to use when creating connections.
+     *
+     * @exception IOException
+     *                in case of server transport failure
+     */
+    public OtpSelf(final String node, final String cookie, final int port,
+            final OtpTransportFactory transportFactory) throws IOException {
+        super(node, cookie, transportFactory);
+
+        sock = createServerTransport(port);
+
+        if (port != 0) {
+            this.port = port;
+        } else {
+            this.port = sock.getLocalPort();
+        }
+
+        pid = createPid();
     }
 
     /**
@@ -106,12 +212,12 @@ public class OtpSelf extends OtpLocalNode {
      * messages sent by this node. Anonymous messages are those sent via send
      * methods in {@link OtpConnection OtpConnection} that do not specify a
      * sender.
-     * 
+     *
      * @return the Erlang PID that will be used as the sender id in all
      *         anonymous messages sent by this node.
      */
     public OtpErlangPid pid() {
-	return pid;
+        return pid;
     }
 
     /**
@@ -119,31 +225,31 @@ public class OtpSelf extends OtpLocalNode {
      * connect to this one. This method establishes a connection to the Erlang
      * port mapper (Epmd) and registers the server node's name and port so that
      * remote nodes are able to connect.
-     * 
+     *
      * <p>
      * This method will fail if an Epmd process is not running on the localhost.
      * See the Erlang documentation for information about starting Epmd.
-     * 
+     *
      * <p>
      * Note that once this method has been called, the node is expected to be
      * available to accept incoming connections. For that reason you should make
      * sure that you call {@link #accept()} shortly after calling
      * {@link #publishPort()}. When you no longer intend to accept connections
      * you should call {@link #unPublishPort()}.
-     * 
+     *
      * @return true if the operation was successful, false if the node was
      *         already registered.
-     * 
+     *
      * @exception java.io.IOException
-     *                    if the port mapper could not be contacted.
+     *                if the port mapper could not be contacted.
      */
     public boolean publishPort() throws IOException {
-	if (getEpmd() != null) {
-	    return false; // already published
-	}
+        if (getEpmd() != null) {
+            return false; // already published
+        }
 
-	OtpEpmd.publishPort(this);
-	return getEpmd() != null;
+        OtpEpmd.publishPort(this);
+        return getEpmd() != null;
     }
 
     /**
@@ -151,71 +257,71 @@ public class OtpSelf extends OtpLocalNode {
      * mapper, thus preventing any new connections from remote nodes.
      */
     public void unPublishPort() {
-	// unregister with epmd
-	OtpEpmd.unPublishPort(this);
-
-	// close the local descriptor (if we have one)
-	try {
-	    if (super.epmd != null) {
-		super.epmd.close();
-	    }
-	} catch (final IOException e) {/* ignore close errors */
-	}
-	super.epmd = null;
+        // unregister with epmd
+        OtpEpmd.unPublishPort(this);
+
+        // close the local descriptor (if we have one)
+        try {
+            if (super.epmd != null) {
+                super.epmd.close();
+            }
+        } catch (final IOException e) {/* ignore close errors */
+        }
+        super.epmd = null;
     }
 
     /**
      * Accept an incoming connection from a remote node. A call to this method
      * will block until an incoming connection is at least attempted.
-     * 
+     *
      * @return a connection to a remote node.
-     * 
+     *
      * @exception java.io.IOException
-     *                    if a remote node attempted to connect but no common
-     *                    protocol was found.
-     * 
+     *                if a remote node attempted to connect but no common
+     *                protocol was found.
+     *
      * @exception OtpAuthException
-     *                    if a remote node attempted to connect, but was not
-     *                    authorized to connect.
+     *                if a remote node attempted to connect, but was not
+     *                authorized to connect.
      */
     public OtpConnection accept() throws IOException, OtpAuthException {
-	Socket newsock = null;
-
-	while (true) {
-	    try {
-		newsock = sock.accept();
-		return new OtpConnection(this, newsock);
-	    } catch (final IOException e) {
-		try {
-		    if (newsock != null) {
-			newsock.close();
-		    }
-		} catch (final IOException f) {/* ignore close errors */
-		}
-		throw e;
-	    }
-	}
+        OtpTransport newsock = null;
+
+        while (true) {
+            try {
+                newsock = sock.accept();
+                return new OtpConnection(this, newsock);
+            } catch (final IOException e) {
+                try {
+                    if (newsock != null) {
+                        newsock.close();
+                    }
+                } catch (final IOException f) {/* ignore close errors */
+                }
+                throw e;
+            }
+        }
     }
 
     /**
      * Open a connection to a remote node.
-     * 
+     *
      * @param other
-     *                the remote node to which you wish to connect.
-     * 
+     *            the remote node to which you wish to connect.
+     *
      * @return a connection to the remote node.
-     * 
+     *
      * @exception java.net.UnknownHostException
-     *                    if the remote host could not be found.
-     * 
+     *                if the remote host could not be found.
+     *
      * @exception java.io.IOException
-     *                    if it was not possible to connect to the remote node.
-     * 
+     *                if it was not possible to connect to the remote node.
+     *
      * @exception OtpAuthException
-     *                    if the connection was refused by the remote node.
+     *                if the connection was refused by the remote node.
      */
     public OtpConnection connect(final OtpPeer other) throws IOException,
-	    UnknownHostException, OtpAuthException {
-	return new OtpConnection(this, other);
+            UnknownHostException, OtpAuthException {
+        return new OtpConnection(this, other);
     }
 }