diff options
author | Siri Hansen <[email protected]> | 2017-09-19 16:19:24 +0200 |
---|---|---|
committer | Siri Hansen <[email protected]> | 2017-09-19 16:19:24 +0200 |
commit | 3979e914660993a06f1a84dd6e4196181964609a (patch) | |
tree | 917e04f9f023477544329c8c01e8da194d96408e /lib/observer/src/observer_html_lib.erl | |
parent | 84c1db49f0dabac3f000b2bf25af1dc483cfed05 (diff) | |
parent | de4e620a3fbd40e598d8f7da01258979246d0bd0 (diff) | |
download | otp-3979e914660993a06f1a84dd6e4196181964609a.tar.gz otp-3979e914660993a06f1a84dd6e4196181964609a.tar.bz2 otp-3979e914660993a06f1a84dd6e4196181964609a.zip |
Merge branch 'siri/cdv/crash-on-large-dump/OTP-14386' into maint
* siri/cdv/crash-on-large-dump/OTP-14386:
observer: Improve debugging code in test suite
cdv: Add ~tw as formatting option when expanding a term
observer: Remove compiler warnings in test and set warnings_as_errors
cdv: Warn about unsafe crashdump
cdv: Show progress bar while reading big data
cdv: Optimize reading of crashdump with many binaries
cdv: Find end of 'Last calls' section
cdv: Don't mark process as truncated if truncation is after all proc_heaps
cdv: Set ERL_CRASH_DUMP_SECONDS to 0 in cdv scripts
Diffstat (limited to 'lib/observer/src/observer_html_lib.erl')
-rw-r--r-- | lib/observer/src/observer_html_lib.erl | 29 |
1 files changed, 18 insertions, 11 deletions
diff --git a/lib/observer/src/observer_html_lib.erl b/lib/observer/src/observer_html_lib.erl index 3dfcc42ada..a85808a472 100644 --- a/lib/observer/src/observer_html_lib.erl +++ b/lib/observer/src/observer_html_lib.erl @@ -337,17 +337,24 @@ href_proc_bin(From, T, Acc, LTB) -> Size = list_to_integer(SizeStr), PreviewSize = min(Size,10), Id = {list_to_integer(Offset),PreviewSize,list_to_integer(Pos)}, - {ok,PreviewBin} = crashdump_viewer:expand_binary(Id), - PreviewStr = preview_string(Size, PreviewBin), - if LTB -> - href("TARGET=\"expanded\"", - ["#Binary?offset="++Offset++ - "&size="++SizeStr++ - "&pos="++Pos], - PreviewStr); - true -> - PreviewStr - end; + case crashdump_viewer:expand_binary(Id) of + {ok, '#CDVTruncatedBinary'} -> + lists:flatten( + "<FONT COLOR=\"#FF0000\">" + "<<...(Truncated Binary)>>" + "</FONT>"); + {ok, PreviewBin} -> + PreviewStr = preview_string(Size, PreviewBin), + if LTB -> + href("TARGET=\"expanded\"", + ["#Binary?offset="++Offset++ + "&size="++SizeStr++ + "&pos="++Pos], + PreviewStr); + true -> + PreviewStr + end + end; [PreviewIntStr,SizeStr,Md5] when From =:= obs -> Size = list_to_integer(SizeStr), PreviewInt = list_to_integer(PreviewIntStr), |