aboutsummaryrefslogtreecommitdiffstats
path: root/lib/ssl/src/tls_v1.erl
diff options
context:
space:
mode:
authorPéter Dimitrov <[email protected]>2018-11-30 13:39:10 +0100
committerPéter Dimitrov <[email protected]>2019-01-11 09:59:12 +0100
commita3a147e86b8ab2b878d91a80f8f276d9ec2f2940 (patch)
tree72135e785a57b52acd74c400c0552198ab1c9050 /lib/ssl/src/tls_v1.erl
parent88733e3e2e9b7e15fac74a42e813da4f19f86482 (diff)
downloadotp-a3a147e86b8ab2b878d91a80f8f276d9ec2f2940.tar.gz
otp-a3a147e86b8ab2b878d91a80f8f276d9ec2f2940.tar.bz2
otp-a3a147e86b8ab2b878d91a80f8f276d9ec2f2940.zip
ssl: Fix handling of signature algorithms
Change-Id: I5cc6b470ea19e32dd5516a86fe6750c5b51d5368
Diffstat (limited to 'lib/ssl/src/tls_v1.erl')
-rw-r--r--lib/ssl/src/tls_v1.erl11
1 files changed, 8 insertions, 3 deletions
diff --git a/lib/ssl/src/tls_v1.erl b/lib/ssl/src/tls_v1.erl
index d018f613c9..5e3140114d 100644
--- a/lib/ssl/src/tls_v1.erl
+++ b/lib/ssl/src/tls_v1.erl
@@ -514,7 +514,9 @@ signature_algs({3, 3}, HashSigns) ->
lists:reverse(Supported).
default_signature_algs({3, 4} = Version) ->
- default_signature_schemes(Version);
+ %% TLS 1.3 servers shall be prepared to process TLS 1.2 ClientHellos
+ %% containing legacy hash-sign tuples.
+ default_signature_schemes(Version) ++ default_signature_algs({3,3});
default_signature_algs({3, 3} = Version) ->
Default = [%% SHA2
{sha512, ecdsa},
@@ -540,7 +542,7 @@ signature_schemes(Version, SignatureSchemes) when is_tuple(Version)
Hashes = proplists:get_value(hashs, CryptoSupports),
PubKeys = proplists:get_value(public_keys, CryptoSupports),
Curves = proplists:get_value(curves, CryptoSupports),
- Fun = fun (Scheme, Acc) ->
+ Fun = fun (Scheme, Acc) when is_atom(Scheme) ->
{Hash0, Sign0, Curve} =
ssl_cipher:scheme_to_components(Scheme),
Sign = case Sign0 of
@@ -561,7 +563,10 @@ signature_schemes(Version, SignatureSchemes) when is_tuple(Version)
[Scheme | Acc];
false ->
Acc
- end
+ end;
+ %% Special clause for filtering out the legacy hash-sign tuples.
+ (_ , Acc) ->
+ Acc
end,
Supported = lists:foldl(Fun, [], SignatureSchemes),
lists:reverse(Supported);