diff options
| author | Björn Gustavsson <[email protected]> | 2012-01-18 14:52:01 +0100 |
|---|---|---|
| committer | Björn Gustavsson <[email protected]> | 2012-01-18 14:52:01 +0100 |
| commit | 629b82f49b68f7189f5bd93f72c5ddc3eb9a7460 (patch) | |
| tree | 8a0398be0ca526253d1b0cfaee36e8f40331c2ae /lib/stdlib/test | |
| parent | 9a32176dac422146982192fb1be95d4a246efeef (diff) | |
| parent | e3b658cbc9b5838ed2596cc30790c26bfa90953f (diff) | |
| download | otp-629b82f49b68f7189f5bd93f72c5ddc3eb9a7460.tar.gz otp-629b82f49b68f7189f5bd93f72c5ddc3eb9a7460.tar.bz2 otp-629b82f49b68f7189f5bd93f72c5ddc3eb9a7460.zip | |
Merge branch 'bjorn/compiler/bif-call-bug/OTP-9866' into maint
* bjorn/compiler/bif-call-bug/OTP-9866:
erl_lint: Consistently reject local calls from guards
Diffstat (limited to 'lib/stdlib/test')
| -rw-r--r-- | lib/stdlib/test/erl_lint_SUITE.erl | 19 |
1 files changed, 18 insertions, 1 deletions
diff --git a/lib/stdlib/test/erl_lint_SUITE.erl b/lib/stdlib/test/erl_lint_SUITE.erl index 9041adbe5c..e4c7fd5b02 100644 --- a/lib/stdlib/test/erl_lint_SUITE.erl +++ b/lib/stdlib/test/erl_lint_SUITE.erl @@ -2631,7 +2631,24 @@ bif_clash(Config) when is_list(Config) -> binary_part(A,B,C). ">>, [warn_unused_import], - {warnings,[{2,erl_lint,{redefine_bif_import,{binary_part,3}}}]}} + {warnings,[{2,erl_lint,{redefine_bif_import,{binary_part,3}}}]}}, + %% Don't accept call to a guard BIF if there is a local definition + %% or an import with the same name. + {clash21, + <<"-export([is_list/1]). + -import(x, [is_tuple/1]). + x(T) when is_tuple(T) -> ok; + x(T) when is_list(T) -> ok. + y(T) when is_tuple(T) =:= true -> ok; + y(T) when is_list(T) =:= true -> ok. + is_list(_) -> + ok. + ">>, + [{no_auto_import,[{is_tuple,1}]}], + {errors,[{3,erl_lint,{illegal_guard_local_call,{is_tuple,1}}}, + {4,erl_lint,{illegal_guard_local_call,{is_list,1}}}, + {5,erl_lint,{illegal_guard_local_call,{is_tuple,1}}}, + {6,erl_lint,{illegal_guard_local_call,{is_list,1}}}],[]}} ], ?line [] = run(Config, Ts), |