Merge branch 'bjorn/maps'

* bjorn/maps:
  Document the new {badmap,Term} and {badkey,Key} exceptions
  Raise more descriptive error messages for failed map operations
  erl_term.h: Add is_not_map() macro
  Tigthen code for the i_get_map_elements/3 instruction
  Pre-compute hash values for the general get_map_elements instruction
  Teach the loader to pre-compute the hash value for single-key lookups
  Optimize use of i_get_map_element/4
  beam_emu: Slightly optimize update_map_{assoc,exact}
  v3_codegen: Don't sort map keys in map creation/update
  beam_validator: No longer require strict literal term order
  Sort maps keys in the loader
  De-optimize the has_map_fields instructions
  erts/map_SUITE.erl: Add a test case that tests has_map_fields
  Fully evaluate is_map/1 for literals at load-time
  map_SUITE: Add tests of is_map/1 with literal maps
  Run a clone of map_SUITE without optimizations
  Remove the fail label operand of the new_map instruction
  Correct transformation of put_map_assoc to new_map
  Remove support for put_map_exact without a source map

3 files changed, 51 insertions, 18 deletions

diff --git a/lib/stdlib/doc/src/maps.xml b/lib/stdlib/doc/src/maps.xml
index f766c843be..59c26d9896 100644
--- a/lib/stdlib/doc/src/maps.xml
+++ b/lib/stdlib/doc/src/maps.xml
@@ -40,6 +40,9 @@
 					Returns a tuple <c>{ok, Value}</c> where <c><anno>Value</anno></c> is the value associated with <c><anno>Key</anno></c>,
 					or <c>error</c> if no value is associated with <c><anno>Key</anno></c> in <c><anno>Map</anno></c>. 
 				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map</anno></c> is not a map.
+				</p>
 				<p>Example:</p>
 				<code type="none">
 > Map = #{"hi" => 42},
@@ -95,8 +98,10 @@
 				<p>
 					Returns the value <c><anno>Value</anno></c> associated with <c><anno>Key</anno></c> if
 					<c><anno>Map</anno></c> contains <c><anno>Key</anno></c>.
-					If no value is associated with <c><anno>Key</anno></c> then the call will
-					fail with an exception.
+				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map</anno></c> is not a map,
+					or with a <c>{badkey,Key}</c> exception if no value is associated with <c><anno>Key</anno></c>.
 				</p>
 				<p>Example:</p>
 				<code type="none">
@@ -116,6 +121,10 @@
 					<c><anno>Map</anno></c> contains <c><anno>Key</anno></c>.
 					If no value is associated with <c><anno>Key</anno></c> then returns <c><anno>Default</anno></c>.
 				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map</anno></c> is not a map.
+
+				</p>
 				<p>Example:</p>
 				<code type="none">
 > Map = #{ key1 => val1, key2 => val2 }.
@@ -134,7 +143,9 @@ val1
 				<p>
 					Returns <c>true</c> if map <c><anno>Map</anno></c> contains <c><anno>Key</anno></c> and returns
 					<c>false</c> if it does not contain the <c><anno>Key</anno></c>.
-					The function will fail with an exception if <c><anno>Map</anno></c> is not a Map.
+				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map</anno></c> is not a map.
 				</p>
 				<p>Example:</p>
 				<code type="none">
@@ -154,6 +165,9 @@ false</code>
 				<p>
 					Returns a complete list of keys, in arbitrary order, which resides within <c><anno>Map</anno></c>.
 				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map</anno></c> is not a map.
+				</p>
 				<p>Example:</p>
 				<code type="none">
 > Map = #{42 => value_three,1337 => "value two","a" => 1},
@@ -189,6 +203,10 @@ false</code>
 					Merges two maps into a single map <c><anno>Map3</anno></c>. If two keys exists in both maps the
 					value in <c><anno>Map1</anno></c> will be superseded by the value in <c><anno>Map2</anno></c>.
 				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map1</anno></c> or
+					<c><anno>Map2</anno></c> is not a map.
+				</p>
 				<p>Example:</p>
 				<code type="none">
 > Map1 = #{a => "value_one", b => "value_two"},
@@ -222,6 +240,10 @@ false</code>
 					replaced by value <c><anno>Value</anno></c>. The function returns a new map <c><anno>Map2</anno></c> containing the new association and
 					the old associations in <c><anno>Map1</anno></c>.
 				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map1</anno></c> is not a map.
+				</p>
+
 				<p>Example:</p>
 				<code type="none">
 > Map = #{"a" => 1}.
@@ -241,6 +263,9 @@ false</code>
 					The function removes the <c><anno>Key</anno></c>, if it exists, and its associated value from
 					<c><anno>Map1</anno></c> and returns a new map <c><anno>Map2</anno></c> without key <c><anno>Key</anno></c>.
 				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map1</anno></c> is not a map.
+				</p>
 				<p>Example:</p>
 				<code type="none">
 > Map = #{"a" => 1}.
@@ -276,6 +301,9 @@ false</code>
 					The fuction returns a list of pairs representing the key-value associations of <c><anno>Map</anno></c>,
 					where the pairs, <c>[{K1,V1}, ..., {Kn,Vn}]</c>, are returned in arbitrary order.
 				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map</anno></c> is not a map.
+				</p>
 				<p>Example:</p>
 				<code type="none">
 > Map = #{42 => value_three,1337 => "value two","a" => 1},
@@ -291,8 +319,11 @@ false</code>
 				<p>
 					If <c><anno>Key</anno></c> exists in <c><anno>Map1</anno></c> the old associated value is
 					replaced by value <c><anno>Value</anno></c>. The function returns a new map <c><anno>Map2</anno></c> containing
-					the new associated value. If <c><anno>Key</anno></c> does not exist in <c><anno>Map1</anno></c> an exception is
-					generated.
+					the new associated value.
+				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map1</anno></c> is not a map,
+					or with a <c>{badkey,Key}</c> exception if no value is associated with <c><anno>Key</anno></c>.
 				</p>
 				<p>Example:</p>
 				<code type="none">
@@ -310,6 +341,9 @@ false</code>
 				<p>
 					Returns a complete list of values, in arbitrary order, contained in map <c>M</c>.
 				</p>
+				<p>
+					The call will fail with a <c>{badmap,Map}</c> exception if <c><anno>Map</anno></c> is not a map.
+				</p>
 				<p>Example:</p>
 				<code type="none">
 > Map = #{42 => value_three,1337 => "value two","a" => 1},
diff --git a/lib/stdlib/src/erl_eval.erl b/lib/stdlib/src/erl_eval.erl
index 371573dc23..e86e10b170 100644
--- a/lib/stdlib/src/erl_eval.erl
+++ b/lib/stdlib/src/erl_eval.erl
@@ -246,18 +246,14 @@ expr({record,_,_,Name,_}, _Bs, _Lf, _Ef, _RBs) ->
 %% map
 expr({map,_,Binding,Es}, Bs0, Lf, Ef, RBs) ->
     {value, Map0, Bs1} = expr(Binding, Bs0, Lf, Ef, none),
-    case Map0 of
-        #{} ->
-            {Vs,Bs2} = eval_map_fields(Es, Bs0, Lf, Ef),
-            Map1 = lists:foldl(fun ({map_assoc,K,V}, Mi) ->
-                                       maps:put(K, V, Mi);
-                                   ({map_exact,K,V}, Mi) ->
-                                       maps:update(K, V, Mi)
-                               end, Map0, Vs),
-            ret_expr(Map1, merge_bindings(Bs2, Bs1), RBs);
-        _ ->
-            erlang:raise(error, {badarg,Map0}, stacktrace())
-    end;
+    {Vs,Bs2} = eval_map_fields(Es, Bs0, Lf, Ef),
+    _ = maps:put(k, v, Map0),			%Validate map.
+    Map1 = lists:foldl(fun ({map_assoc,K,V}, Mi) ->
+			       maps:put(K, V, Mi);
+			   ({map_exact,K,V}, Mi) ->
+			       maps:update(K, V, Mi)
+		       end, Map0, Vs),
+    ret_expr(Map1, merge_bindings(Bs2, Bs1), RBs);
 expr({map,_,Es}, Bs0, Lf, Ef, RBs) ->
     {Vs,Bs} = eval_map_fields(Es, Bs0, Lf, Ef),
     ret_expr(lists:foldl(fun
diff --git a/lib/stdlib/test/erl_eval_SUITE.erl b/lib/stdlib/test/erl_eval_SUITE.erl
index 3427f431c5..a750c5cace 100644
--- a/lib/stdlib/test/erl_eval_SUITE.erl
+++ b/lib/stdlib/test/erl_eval_SUITE.erl
@@ -1482,8 +1482,11 @@ eep43(Config) when is_list(Config) ->
 	  "    #{ K1 := 1, K2 := 2, K3 := 3, {2,2} := 4} = Map "
 	  "end.",
 	  #{ 1 => 1, <<42:301>> => 2, {3,<<42:301>>} => 3, {2,2} => 4}),
-    error_check("[camembert]#{}.", {badarg,[camembert]}),
+    error_check("[camembert]#{}.", {badmap,[camembert]}),
+    error_check("[camembert]#{nonexisting:=v}.", {badmap,[camembert]}),
     error_check("#{} = 1.", {badmatch,1}),
+    error_check("[]#{a=>error(bad)}.", bad),
+    error_check("(#{})#{nonexisting:=value}.", {badkey,nonexisting}),
     ok.
 
 %% Check the string in different contexts: as is; in fun; from compiled code.