aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2016-09-02Fix overridden BIFsBjörn Gustavsson
The filters in a list comprehension can be guard expressions or an ordinary expressions. If a guard expression is used as a filter, an exception will basically mean the same as 'false': t() -> L = [{some_tag,42},an_atom], [X || X <- L, element(1, X) =:= some_tag] %% Returns [{some_tag,42}] On the other hand, if an ordinary expression is used as a filter, there will be an exception: my_element(N, T) -> element(N, T). t() -> L = [{some_tag,42},an_atom], [X || X <- L, my_element(1, X) =:= some_tag] %% Causes a 'badarg' exception when element(1, an_atom) is evaluated It has been allowed for several releases to override a BIF with a local function. Thus, if we define a function called element/2, it will be called instead of the BIF element/2 within the module. We must use the "erlang:" prefix to call the BIF. Therefore, the following code is expected to work the same way as in our second example above: -compile({no_auto_import,[element/2]}). element(N, T) -> erlang:element(N, T). t() -> L = [{some_tag,42},an_atom], [X || X <- L, element(1, X) =:= some_tag]. %% Causes a 'badarg' exception when element(1, an_atom) is evaluated But the compiler refuses to compile the code with the following diagnostic: call to local/imported function element/2 is illegal in guard
2016-09-02Don't crash when obsolete guard overrides local functionBjörn Gustavsson
The compiler would crash in v3_codegen when trying to compile the following code: is_port(_) -> false. foo(P) when port(P) -> ok. We *could* have the compiler interpret the code as: is_port(_) -> false. foo(P) when erlang:is_port(P) -> ok. But that would encourage using the obsolete form of the guard tests. Note that the following code is illegal: is_port(_) -> false. foo(P) when is_port(P) -> ok. It produces the following diagnostic: call to local/imported function is_port/1 is illegal in guard Therefore, we should refuse to compile the code.
2016-09-02Update primary bootstrapBjörn Gustavsson
2016-09-02Merge branch 'bjorn/eliminate-sys_pre_expand/OTP-13856'Björn Gustavsson
* bjorn/eliminate-sys_pre_expand/OTP-13856: Remove sys_pre_expand xref: Eliminate use of sys_pre_expand debugger: Eliminate use of sys_pre_expand compiler: Eliminate use of sys_pre_expand shell_SUITE: Eliminate references to sys_pre_expand in comments qlc_pt: Simplify code because of updated erl_expand_records Teach erl_expand_records to translate module-less calls erl_internal: Add add_predefined_functions/1 cover: Remove always stale comment
2016-09-02Merge branch 'maint'Hans Bolinder
* maint: Fix documentation of an option of erl_tidy
2016-09-02Merge branch 'fenollp/syntax_tools/erl_tidy_option/PR-1151' into maintHans Bolinder
* fenollp/syntax_tools/erl_tidy_option/PR-1151: Fix documentation of an option of erl_tidy
2016-09-02Merge branch 'maint'Hans Bolinder
* maint: doc: Correct errors introduced by Editorial changes
2016-09-02Merge branch 'hasse/doc/fix_editorial_changes' into maintHans Bolinder
* hasse/doc/fix_editorial_changes: doc: Correct errors introduced by Editorial changes
2016-09-01Merge branch 'rickard/default-dirty-schedulers/OTP-13860'Rickard Green
* rickard/default-dirty-schedulers/OTP-13860: Enable dirty scheduler support as default
2016-09-01Enable dirty scheduler support as defaultRickard Green
2016-09-01Merge branch 'rickard/remove-old-purge-strategy/OTP-13844'Rickard Green
* rickard/remove-old-purge-strategy/OTP-13844: Avoid selective receive in code-purger process Remove old purge strategy Conflicts: erts/emulator/beam/beam_bif_load.c erts/emulator/beam/global.h
2016-09-01Merge branch 'maint'Rickard Green
* maint: Fix reclaim of literal areas Conflicts: erts/emulator/beam/global.h
2016-09-01Merge branch 'rickard/new-purge-strategy/OTP-13833' into maintRickard Green
* rickard/new-purge-strategy/OTP-13833: Fix reclaim of literal areas Conflicts: erts/emulator/beam/beam_bif_load.c
2016-09-01Remove sys_pre_expandBjörn Gustavsson
The previous commits have made sys_pre_expand superfluous. Since sys_pre_expand is undocumented and unsupported it can be removed in a major release without prior deprecation. Also remove code in erl_parse that handles abstract code that has passed through sys_pre_expand. We considered deprecating sys_pre_expand just in case, but decided against it for the following reasons: - Anyone brave and knowledgeable enough to use sys_pre_expand should be able to cope with sys_pre_expand being removed. - If we kept it, but didn't test it anywhere in OTP, it could potentially stop working. So we would probably have to add some test cases.
2016-09-01xref: Eliminate use of sys_pre_expandBjörn Gustavsson
2016-09-01debugger: Eliminate use of sys_pre_expandBjörn Gustavsson
2016-09-01compiler: Eliminate use of sys_pre_expandBjörn Gustavsson
sys_pre_expand previously did a lot more work, for example, translating records and funs, but now is merely a grab bag of small transformations. Move those transformations to v3_core.
2016-09-01shell_SUITE: Eliminate references to sys_pre_expand in commentsBjörn Gustavsson
Make it clear that we test that the shell is not dependent on the compiler application being in the path.
2016-09-01qlc_pt: Simplify code because of updated erl_expand_recordsBjörn Gustavsson
erl_expand_records now adds "erlang:" to calls to BIFs, so we can simplify the code.
2016-09-01Teach erl_expand_records to translate module-less callsBjörn Gustavsson
As the next step in eliminating sys_pre_expand, teach erl_expand_records to handle calls without explicit module name. If such call refer to a BIF or imported function, add an explicit module name. That means that any subsequent pass will know that a call without a module name is always to a local function defined in the module.
2016-09-01erl_internal: Add add_predefined_functions/1Björn Gustavsson
The sys_pre_expand module used to do a lot more (translate records and funs, for example), but now it does very little. Most of the code is an identify transformation of the abstract format. The identity transformation part of the code must be maintained and kept correct when new forms are added to the abstract format. That adds to the maintance burden. It also adds (slightly) to compilation times. Therefore, we want to eliminate sys_pre_expand, moving all of its (non-identity) transformations to better places. As a preliminary first step, move the code that adds the pre-defined functions (such as module_info/0) to a new function in erl_internal.
2016-09-01cover: Remove always stale commentBjörn Gustavsson
The comment in the catch-all clause in munge_expr/2 will always be stale. There is no way it can be kept up to date. For example, 'eof' is listed, but 'eof' is a top-level form and is actually handled in the catch-all clause for munge/4.
2016-09-01Merge branch 'maint'Björn Gustavsson
* maint: beam_lib: Correct type for the abstract code chunk
2016-09-01Fix reclaim of literal areasRickard Green
2016-09-01beam_lib: Correct type for the abstract code chunkBjörn Gustavsson
The abstract_code chunk can also contain {eof,_}, {error,_}, and {warning,_} in addition to the abstract forms that make up the Erlang syntax proper.
2016-09-01doc: Correct errors introduced by Editorial changesHans Bolinder
Fix some older errors as well.
2016-09-01Merge branch 'maint'Dan Gudmundsson
* maint: observer: Fix error msg loop in table viewer
2016-09-01Merge branch 'dgud/observer/table-viewer-bug/ERL-237/OTP-13845' into maintDan Gudmundsson
* dgud/observer/table-viewer-bug/ERL-237/OTP-13845: observer: Fix error msg loop in table viewer
2016-09-01observer: Fix error msg loop in table viewerDan Gudmundsson
When observing mnesia table on remote node and connection to that node is lost, a loop of error messages occur if mnesia is not running on the observer node. ERL-237
2016-09-01Merge branch 'maint'Hans Bolinder
* maint: dialyzer: Increase time limit of suites dialyzer: Remove a check that always fails dialyzer: Optimize an opaque type case
2016-09-01Merge branch 'hasse/dialyzer/fix_forms_to_type/OTP-13682' into maintHans Bolinder
* hasse/dialyzer/fix_forms_to_type/OTP-13682: dialyzer: Increase time limit of suites dialyzer: Remove a check that always fails dialyzer: Optimize an opaque type case
2016-09-01Merge branch 'maint'Hans Bolinder
* maint: Fix xmllint-warnings
2016-09-01Merge branch 'hasse/doc/fix_xmllint_warnings' into maintHans Bolinder
* hasse/doc/fix_xmllint_warnings: Fix xmllint-warnings
2016-08-31Fix documentation of an option of erl_tidyPierre Fenoll
2016-08-31Merge branch 'maint'Dan Gudmundsson
* maint: Emacs: make tags unit test more robust Emacs: extend support for compile options Function instead of lambda in advice Enable tag completion in emacs erlang shell
2016-08-31Merge branch 'dgud/tools/emacs-mode-tag-fixes/PR-1106' into maintDan Gudmundsson
* dgud/tools/emacs-mode-tag-fixes/PR-1106: Emacs: make tags unit test more robust Emacs: extend support for compile options Function instead of lambda in advice Enable tag completion in emacs erlang shell
2016-08-31Emacs: make tags unit test more robustJohan Claesson
2016-08-31Emacs: extend support for compile optionsJohan Claesson
The syntax was limited to atoms, strings and 2-tuples. This covers most compile options but not for example {d,Macro,Value}. Add support for N-tuples and lists. Add a related unit test case.
2016-08-31Function instead of lambda in adviceJohan Claesson
Lambda advice cannot easily be updated.
2016-08-31Enable tag completion in emacs erlang shellJohan Claesson
Completion in erlang shell buffer only works in Emacs 25. Minor cleanup of completion stuff. Add test-case for completion at point. Avoid inf-loop in erlang-end-of-clause when buffer starts with whitespace.
2016-08-31Merge branch 'maint'Rickard Green
* maint: Ensure correct mbuf_sz value in process structure
2016-08-31Merge branch 'rickard/mbuf_sz/OTP-13851' into maintRickard Green
* rickard/mbuf_sz/OTP-13851: Ensure correct mbuf_sz value in process structure
2016-08-31dialyzer: Increase time limit of suitesHans Bolinder
The test 'proper' takes some time.
2016-08-31dialyzer: Remove a check that always failsHans Bolinder
2016-08-31dialyzer: Optimize an opaque type caseHans Bolinder
Fix a mistake in commit 85f6fe3b. Instead of using the declared opaque type, the form's type is used in a case where the opaque type is turned into a non-opaque type. The result is more general types (smaller Erlang terms) and faster analyses.
2016-08-31Merge branch 'maint'Rickard Green
* maint: Improve accuracy of timeouts using premature timeouts
2016-08-31Merge branch 'rickard/premature-timeout/OTP-13698' into maintRickard Green
* rickard/premature-timeout/OTP-13698: Improve accuracy of timeouts using premature timeouts
2016-08-31Merge branch 'maint'Rickard Green
* maint: Fix is-dirty-cpu/is-dirty-io scheduler predicates
2016-08-31Merge branch 'rickard/ds-pred/OTP-13852' into maintRickard Green
* rickard/ds-pred/OTP-13852: Fix is-dirty-cpu/is-dirty-io scheduler predicates
2016-08-31Fix xmllint-warningsHans Bolinder